Skip to content

add Windows script #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add Windows script #13

wants to merge 1 commit into from

Conversation

mattn
Copy link
Contributor

@mattn mattn commented May 23, 2025

No description provided.

@darthorimar darthorimar self-assigned this May 26, 2025
Copy link
Collaborator

@darthorimar darthorimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM overall


set "SOURCE=%~f0"

:resolve_symlink
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be an unused label. Also, the %%~dpF will not resolve the symlinks

)

set "JAVA_BIN=java"
if defined JAVA_HOME (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If java home is not set, then the if not exist "%JAVA_BIN%" check will not be performed

@darthorimar
Copy link
Collaborator

Thank you, merged: af641a6. Feel free to follow up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants